fix(vm): Fix VM divergence in revert data #3570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
commented
Feb 6, 2025
slowli
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88,
iluwaa,
Deniallugo and
joonazan
6 tasks
perekopskiy
approved these changes
Mar 24, 2025
artmakh
approved these changes
Mar 24, 2025
slowli
deleted the
aov-pla-1089-investigate-vm-divergences-in-api-server-reverts
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
🤖 I have created a release *beep* *boop* --- ## [27.1.0](core-v27.0.0...core-v27.1.0) (2025-03-27) ### Features * **consensus:** Add consensus protocol versioning ([#3720](#3720)) ([d1b4308](d1b4308)) * **zkos:** Implement ZK OS tree manager ([#3730](#3730)) ([efc0007](efc0007)) ### Bug Fixes * **api:** Fix panic applying nonce override ([#3748](#3748)) ([944059b](944059b)) * **contract_verifier:** order deploy events in `get_contract_info_for_verification` ([#3766](#3766)) ([6e3c031](6e3c031)) * make proof data handler backwards compatible ([#3767](#3767)) ([bdbbaaa](bdbbaaa)) * **proof_data_handler:** update save_proof_artifacts_metadata UPDATE ([#3758](#3758)) ([ed4926f](ed4926f)) * **vm:** Fix VM divergence in revert data ([#3570](#3570)) ([b82e2e4](b82e2e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
🤖 I have created a release *beep* *boop* --- ## [27.1.0](core-v27.0.0...core-v27.1.0) (2025-03-27) ### Features * **consensus:** Add consensus protocol versioning ([#3720](#3720)) ([1e3d17e](1e3d17e)) * **zkos:** Implement ZK OS tree manager ([#3730](#3730)) ([efc0007](efc0007)) ### Bug Fixes * **api:** Fix panic applying nonce override ([#3748](#3748)) ([944059b](944059b)) * **contract_verifier:** order deploy events in `get_contract_info_for_verification` ([#3766](#3766)) ([6e3c031](6e3c031)) * make proof data handler backwards compatible ([#3767](#3767)) ([d7b0122](d7b0122)) * **proof_data_handler:** update save_proof_artifacts_metadata UPDATE ([#3758](#3758)) ([ed4926f](ed4926f)) * **vm:** Fix VM divergence in revert data ([#3570](#3570)) ([b82e2e4](b82e2e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
dutterbutter
pushed a commit
to dutterbutter/zkstack-cli
that referenced
this pull request
Jul 3, 2025
🤖 I have created a release *beep* *boop* --- ## [27.1.0](matter-labs/zksync-era@core-v27.0.0...core-v27.1.0) (2025-03-27) ### Features * **consensus:** Add consensus protocol versioning ([#3720](matter-labs/zksync-era#3720)) ([15771c5](matter-labs/zksync-era@15771c5)) * **zkos:** Implement ZK OS tree manager ([#3730](matter-labs/zksync-era#3730)) ([efc0007](matter-labs/zksync-era@efc0007)) ### Bug Fixes * **api:** Fix panic applying nonce override ([#3748](matter-labs/zksync-era#3748)) ([944059b](matter-labs/zksync-era@944059b)) * **contract_verifier:** order deploy events in `get_contract_info_for_verification` ([#3766](matter-labs/zksync-era#3766)) ([6e3c031](matter-labs/zksync-era@6e3c031)) * make proof data handler backwards compatible ([#3767](matter-labs/zksync-era#3767)) ([c1788df](matter-labs/zksync-era@c1788df)) * **proof_data_handler:** update save_proof_artifacts_metadata UPDATE ([#3758](matter-labs/zksync-era#3758)) ([ed4926f](matter-labs/zksync-era@ed4926f)) * **vm:** Fix VM divergence in revert data ([#3570](matter-labs/zksync-era#3570)) ([b82e2e4](matter-labs/zksync-era@b82e2e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Fixes the result tracer of the legacy VM so that it doesn't return random-ish revert data in marginal cases.
Why ❔
The revert data should be correct.
Checklist
zkstack dev fmtandzkstack dev lint.