feat(api): Allow EVM bytecode overrides #3761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
previously approved these changes
Mar 28, 2025
itegulov
previously approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Just want to highlight that IMHO we should not extend auto-detection any further and any additional bytecode kind we might accept in the future should be supplied with a marker. It's not ideal that we are baking this extra modification into an existing ETH method but I understand the reasoning behind it.
One extra thing I would love to see is metrics for bytecode kinds: specifically if the request contained a marker vs we had to detect one automatically (and what it resulted into). Assuming ZKsync tooling starts using markers as soon as this gets rolled out to the vast majority of envs, we will start seeing the gradual decline of auto-detections resulting into EraVM kind. And, at some point, we will (potentially) have an avenue of enforcing purely EVM bytecode in this endpoint (when no marker is supplied ofc).
But no strong opinion - leaving the decision on metrics up to you
itegulov
approved these changes
Apr 1, 2025
slowli
deleted the
aov-evm-962-allow-evm-bytecode-overrides-in-api-server
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
🤖 I have created a release *beep* *boop* --- ## [27.2.0](core-v27.1.0...core-v27.2.0) (2025-04-03) ### Features * **api:** Allow EVM bytecode overrides ([#3761](#3761)) ([8aee9f8](8aee9f8)) * **en:** Allow tree / state keeper cache recovery for genesis ([#3781](#3781)) ([dd18c48](dd18c48)) * **eth_signer:** Support eip712 txs ([#3752](#3752)) ([e278ab5](e278ab5)) * **gateway:** Handle server shutting down error ([#3777](#3777)) ([8e11adc](8e11adc)) * **gateway:** Migration to Gateway ([#3654](#3654)) ([2858ba0](2858ba0)) * **main:** Eigenda add custom quorum params ([#3719](#3719)) ([dac58ad](dac58ad)) * Update zksync-protocol deps to 0.151.5 ([#3790](#3790)) ([92beffe](92beffe)) * **zkos:** remove prev index pointer from leaves ([#3771](#3771)) ([5b8fd29](5b8fd29)) ### Bug Fixes * insert tokens without PG copy ([#3778](#3778)) ([b7a8152](b7a8152)) * **prover:** Force set all the `prover_job` labels to 0 ([#3787](#3787)) ([3ecc8db](3ecc8db)) * **prover:** Reevaluation of 'heavy' jobs for WVG ([#3754](#3754)) ([2a8d33b](2a8d33b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
🤖 I have created a release *beep* *boop* --- ## [27.2.0](core-v27.1.0...core-v27.2.0) (2025-04-03) ### Features * **api:** Allow EVM bytecode overrides ([#3761](#3761)) ([8aee9f8](8aee9f8)) * **en:** Allow tree / state keeper cache recovery for genesis ([#3781](#3781)) ([dd18c48](dd18c48)) * **eth_signer:** Support eip712 txs ([#3752](#3752)) ([e278ab5](e278ab5)) * **gateway:** Handle server shutting down error ([#3777](#3777)) ([8e11adc](8e11adc)) * **gateway:** Migration to Gateway ([#3654](#3654)) ([c861ce1](c861ce1)) * **main:** Eigenda add custom quorum params ([#3719](#3719)) ([dac58ad](dac58ad)) * Update zksync-protocol deps to 0.151.5 ([#3790](#3790)) ([92beffe](92beffe)) * **zkos:** remove prev index pointer from leaves ([#3771](#3771)) ([5b8fd29](5b8fd29)) ### Bug Fixes * insert tokens without PG copy ([#3778](#3778)) ([b7a8152](b7a8152)) * **prover:** Force set all the `prover_job` labels to 0 ([#3787](#3787)) ([3ecc8db](3ecc8db)) * **prover:** Reevaluation of 'heavy' jobs for WVG ([#3754](#3754)) ([2a8d33b](2a8d33b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
dutterbutter
pushed a commit
to dutterbutter/zkstack-cli
that referenced
this pull request
Jul 3, 2025
🤖 I have created a release *beep* *boop* --- ## [27.2.0](matter-labs/zksync-era@core-v27.1.0...core-v27.2.0) (2025-04-03) ### Features * **api:** Allow EVM bytecode overrides ([#3761](matter-labs/zksync-era#3761)) ([8aee9f8](matter-labs/zksync-era@8aee9f8)) * **en:** Allow tree / state keeper cache recovery for genesis ([#3781](matter-labs/zksync-era#3781)) ([dd18c48](matter-labs/zksync-era@dd18c48)) * **eth_signer:** Support eip712 txs ([#3752](matter-labs/zksync-era#3752)) ([e278ab5](matter-labs/zksync-era@e278ab5)) * **gateway:** Handle server shutting down error ([#3777](matter-labs/zksync-era#3777)) ([8e11adc](matter-labs/zksync-era@8e11adc)) * **gateway:** Migration to Gateway ([#3654](matter-labs/zksync-era#3654)) ([3c5e3c1](matter-labs/zksync-era@3c5e3c1)) * **main:** Eigenda add custom quorum params ([#3719](matter-labs/zksync-era#3719)) ([dac58ad](matter-labs/zksync-era@dac58ad)) * Update zksync-protocol deps to 0.151.5 ([#3790](matter-labs/zksync-era#3790)) ([92beffe](matter-labs/zksync-era@92beffe)) * **zkos:** remove prev index pointer from leaves ([#3771](matter-labs/zksync-era#3771)) ([5b8fd29](matter-labs/zksync-era@5b8fd29)) ### Bug Fixes * insert tokens without PG copy ([#3778](matter-labs/zksync-era#3778)) ([b7a8152](matter-labs/zksync-era@b7a8152)) * **prover:** Force set all the `prover_job` labels to 0 ([#3787](matter-labs/zksync-era#3787)) ([3ecc8db](matter-labs/zksync-era@3ecc8db)) * **prover:** Reevaluation of 'heavy' jobs for WVG ([#3754](matter-labs/zksync-era#3754)) ([2a8d33b](matter-labs/zksync-era@2a8d33b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Allows to accept EVM bytecode overrides in the relevant API server methods like
eth_callandeth_estimateGas.Why ❔
With EVM emulator, we want to support EVM bytecodes everywhere, including in state overrides.
Is this a breaking change?
Technically, a highly unusual EraVM bytecode can be incorrectly detected as an EVM bytecode, but the possibility of this occurring in practice is vanishingly small. E.g., there doesn't seem to be a single functional "unusual" bytecode deployed on the Era mainnet.
Operational changes
No operational changes.
Checklist
zkstack dev fmtandzkstack dev lint.