-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(prover): Correctly calculate NeedToMove and recent scale errors #3783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always run all clusters evaluation to makes sure that metrics area correct and min_replicas works. ref ZKD-2533
EmilLuta
reviewed
Mar 31, 2025
EmilLuta
reviewed
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 nits. I still don't get 1 of the values, but otherwise LGTM.
Artemka374
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
S1nus
pushed a commit
to S1nus/zksync-era
that referenced
this pull request
Apr 3, 2025
🤖 I have created a release *beep* *boop* --- ## [20.1.0](matter-labs/zksync-era@prover-v20.0.0...prover-v20.1.0) (2025-04-02) ### Features * Update zksync-protocol deps to 0.151.5 ([matter-labs#3790](matter-labs#3790)) ([92beffe](matter-labs@92beffe)) ### Bug Fixes * **prover:** Correctly calculate NeedToMove and recent scale errors ([matter-labs#3783](matter-labs#3783)) ([aa46f89](matter-labs@aa46f89)) * **prover:** Force set all the `prover_job` labels to 0 ([matter-labs#3787](matter-labs#3787)) ([3ecc8db](matter-labs@3ecc8db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Correctly calculate NeedToMove and recent scale errors.
Always run all clusters evaluation to makes sure that metrics area correct and min_replicas works.
Add
scale_errors_duration
andneed_to_move_duration
optional config fields.Why ❔
To prevent oscillation pods between clusters, fix min_replicas and output metrics during 0 load.
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmt
andzkstack dev lint
.ref ZKD-2533