Skip to content

Conversation

yorik
Copy link
Contributor

@yorik yorik commented Mar 31, 2025

What ❔

Correctly calculate NeedToMove and recent scale errors.
Always run all clusters evaluation to makes sure that metrics area correct and min_replicas works.
Add scale_errors_duration and need_to_move_duration optional config fields.

Why ❔

To prevent oscillation pods between clusters, fix min_replicas and output metrics during 0 load.

Is this a breaking change?

  • Yes
  • No

Operational changes

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

ref ZKD-2533

yorik added 2 commits March 31, 2025 14:28
Always run all clusters evaluation to makes sure that metrics area
correct and min_replicas works.

ref ZKD-2533
@yorik yorik enabled auto-merge March 31, 2025 12:35
@yorik yorik requested a review from EmilLuta April 1, 2025 08:52
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 nits. I still don't get 1 of the values, but otherwise LGTM.

Copy link
Contributor

@Artemka374 Artemka374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorik yorik added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit aa46f89 Apr 2, 2025
31 checks passed
@yorik yorik deleted the ya-fix-needtomove branch April 2, 2025 16:41
S1nus pushed a commit to S1nus/zksync-era that referenced this pull request Apr 3, 2025
🤖 I have created a release *beep* *boop*
---


##
[20.1.0](matter-labs/zksync-era@prover-v20.0.0...prover-v20.1.0)
(2025-04-02)


### Features

* Update zksync-protocol deps to 0.151.5
([matter-labs#3790](matter-labs#3790))
([92beffe](matter-labs@92beffe))


### Bug Fixes

* **prover:** Correctly calculate NeedToMove and recent scale errors
([matter-labs#3783](matter-labs#3783))
([aa46f89](matter-labs@aa46f89))
* **prover:** Force set all the `prover_job` labels to 0
([matter-labs#3787](matter-labs#3787))
([3ecc8db](matter-labs@3ecc8db))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants