Skip to content

Better DESC extraction #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 25, 2022
Merged

Better DESC extraction #39

merged 6 commits into from
Apr 25, 2022

Conversation

kayoub5
Copy link
Collaborator

@kayoub5 kayoub5 commented Apr 23, 2022 •
edited
Loading

Current implimentation fails for sample below DESC, since the attribute will cause raw_string.startswith("<DESC>") to fail

<DESC TI="some_attribute_value">some value <p> other value</p> end</DESC>

Solution based on https://stackoverflow.com/a/3446055/1438522

andlaus
andlaus reviewed Apr 25, 2022
View reviewed changes
@kayoub5 @andlaus
Update odxtools/utils.py
a87be33 
Co-authored-by: Andreas Lauser <github@poware.org>
kayoub5
kayoub5 commented Apr 25, 2022
View reviewed changes
@andlaus
Copy link
Member

andlaus commented Apr 25, 2022

nice! thanks for the contribution :)

@andlaus andlaus merged commit eb6a266 into mercedes-benz:main Apr 25, 2022
@kayoub5 kayoub5 deleted the patch-1 branch April 25, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andlaus andlaus andlaus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayoub5 @andlaus