tests, examples: Do not explicitly specify parameters which are set to the default value during instantiation #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another long and boring but monotopical commit. This one is probably holding the record for "most lines removed" in odxtools so far :) Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mercedes-benz.com>
|
be aware that -- just like #411 -- I made these changes in a mainly automated manner, so it is possible that some places fell through the cracks... |
kayoub5
reviewed
Apr 7, 2025
Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
…aulted this, if they are 0, they do not need to be specified explicitly. thanks to [at]kayoub5 for the catch. Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
andlaus
force-pushed
the
remove_default_values
branch
from
9845710 to
faee4a0
Compare
kayoub5
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the follow-up to #411, and is another long and boring but monotopical PR. This one is probably holding the record for "most lines removed" in odxtools so far :)
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information