Skip to content

Fix compatibility with ODX v2.0.0 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Fix compatibility with ODX v2.0.0 #55

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bf325f
Fix compatibility with ODX v2.0.0
kayoub5 Aug 17, 2022
546b1e6
make VALUE the first if
kayoub5 Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion odxtools/communicationparameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,12 @@ def _read_complex_value_from_odx(et_element):

def read_communication_param_ref_from_odx(et_element):
id_ref = et_element.get("ID-REF")

# ODX standard v2.0.0 defined only VALUE
# ODX standard v2.0.1 decided to break things and change it to choice between SIMPLE-VALUE and COMPLEX-VALUE
if et_element.find("SIMPLE-VALUE") is not None:
value = et_element.find("SIMPLE-VALUE").text
elif et_element.find("VALUE"):
value = et_element.find("VALUE").text
else:
value = _read_complex_value_from_odx(et_element.find("COMPLEX-VALUE"))

Expand Down