Fix typos, docs, and code style #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dluc
commented
Nov 8, 2024
dluc
commented
- Fix typos
- Fix configuration docs, e.g. use correct section names
- Fix code style
github-actions
bot
added
documentation
TaoChenOSU
reviewed
Nov 9, 2024
| @@ -48,9 +48,9 @@ public PluginController( | |||
| /// <param name="manifestDomain">The domain of the manifest.</param> | |||
| /// <returns>The plugin's manifest JSON.</returns> | |||
| [HttpGet] | |||
| [Route("pluginManifests")] | |||
| [Route("pluginManifests")] // TODO: Fix name and test | |||
There was a problem hiding this comment.
Question: is the TODO intended?
There was a problem hiding this comment.
yes, I believe the name should be singular
TaoChenOSU
previously approved these changes
Nov 9, 2024
dluc
commented
Nov 9, 2024
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
* Fix typos * Fix configuration docs, e.g. use correct section names * Fix code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.