Skip to content

Conversation

GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov commented Mar 16, 2025

Before After
image image

Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 22.91%. Comparing base (49f98be) to head (c49f211).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/components/CalendarGrid.vue 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6827      +/-   ##
============================================
- Coverage     22.95%   22.91%   -0.05%     
  Complexity      476      476              
============================================
  Files           252      252              
  Lines         12266    12290      +24     
  Branches       2362     2364       +2     
============================================
  Hits           2816     2816              
- Misses         9108     9132      +24     
  Partials        342      342              
Flag Coverage Δ
javascript 14.56% <0.00%> (-0.04%) ⬇️
php 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GVodyanov GVodyanov self-assigned this Mar 17, 2025
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Mar 17, 2025
@GVodyanov GVodyanov marked this pull request as ready for review March 17, 2025 14:59
@ChristophWurst
Copy link
Member

Wrong paste/button, sorry. The Darker parts are still weird for the events on the right. I'd expect past events to be equally transparent regardless of overlap or not

@GVodyanov
Copy link
Contributor Author

GVodyanov commented Mar 20, 2025

Well, I made it work with some pretty weird geometry. I hope it isn't too hacky.

image

If anyone has a better idea than using the polygon clipping, that would be good though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants