Optimization of SeparateSubclassVisitor #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I can see why it's faster than previous implementation 👍 Looks good to me |
|
On the other hand, if that's just a wrapper around a HashSet, maybe we can avoid new collection type altogether. I'll take a closer look tomorrow |
|
I can't see the big picture, that's why I wrapped the collection. But if |
|
Is there any progress with this case? |
|
Let me check List vs HashSet with a lot of Type instances in it. I suspect it's much better (O(1) vs O(n)). This will appear in the next release - but I'm not sure when that's happening. |
|
Ok, will wait for the release then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We have rather big code-first NH-model in our project with thousand classes and long hierarchy chains.
Testing showed that from two to five minutes are spent on bulding model. Profiling showed thant 70% time is spent in FluentNHibernate, particulary in SeparateSubclassVisitor.IsMapped method.
I suggest a performance fix that optimizes this method. Now our model builds in less than one minute and most time is spent in NH itself.
We are already using this patched version in our project, but it is likely to have it merged with FNH master for updating reasons.
Any comments are welcome, if you need a model and prototype-project with this properties we can provide it.