DM convert refactor #486
Merged
DM convert refactor #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowekamp
force-pushed
the
dm_convert_refactor
branch
5 times, most recently
from
be87cf7 to
8147f05
Compare
blowekamp
force-pushed
the
dm_convert_refactor
branch
from
8147f05 to
604062d
Compare
Create a function to convert mrc to tiff files with newstack Replace dm->jpeg step with newstack function. Move separate "conditional" tasks into one function.
Also avoid repeated declaration of the same valued variable.
Additionally update all callback results in one task aswell.
This directly run SimpleITK in the python process. It reads and loads the image once, but writes it twice at different resolutions. Thus it is more efficient.
Further reduces the number of tasks in flow.
By taking the max size of the dimensions, the output size will match that of for the required large image. Therefore resizing can be skipped with the newstack output.
philipmac
force-pushed
the
dm_convert_refactor
branch
from
e242bf2 to
1962104
Compare
philipmac
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the dm_convert pipeline.
Create a function to convert mrc to tiff files with newstack
Replace dm->jpeg step with newstack function.
Move separate "conditional" tasks into one function.
Addresses (eg: #1)
Depends on (eg: #1)
Changes
This PR doesn't introduce any:
printstatementsos.environ['user'])This PR contains valid: