chore(cmake): natvis building option #4849
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli <tape-infix.3m@icloud.com>
gregmarr
reviewed
Jul 21, 2025
CMakeLists.txt
Outdated
| @@ -208,7 +209,7 @@ if(JSON_Install) | |||
| FILES ${NLOHMANN_JSON_CMAKE_PROJECT_CONFIG_FILE} ${NLOHMANN_JSON_CMAKE_VERSION_CONFIG_FILE} | |||
| DESTINATION ${NLOHMANN_JSON_CONFIG_INSTALL_DIR} | |||
| ) | |||
| if (NLOHMANN_ADD_NATVIS) | |||
| if (NLOHMANN_ADD_NATVIS AND JSON_BuildNatvis) | |||
There was a problem hiding this comment.
Is this part needed? NLOHMANN_ADD_NATVIS will already not be defined if JSON_BuildNatvis is false.
There was a problem hiding this comment.
yea your right its kinda redundant
Signed-off-by: Eli <78963198+niceEli@users.noreply.github.com>
|
This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions! |
github-actions
bot
added
the
state: stale
github-actions
bot
removed
the
state: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a CMake option to allow choosing whether or not to build the .natvis file, there is no issue for this but it caused some issues with me so I fixed it.
The CMake option
JSON_BuildNatvisbeingONorOFFcontrols its build, it will still not build if MSVC is notON.This wont break anyones projects, but if people want to optionally not build the natvis file then they can.
make amalgamate.Read the Contribution Guidelines for detailed information.