Skip to content

Fix Windows CI #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 28, 2025
Merged

Fix Windows CI #4897

merged 14 commits into from
Aug 28, 2025
+142 −111

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Aug 20, 2025 •
edited
Loading

  • set proper flags to compile tests with Clang
  • pass CMAKE_CXX_FLAGS to all CMake test projects
  • set /EHsc for all CMake test projects to satisfy MSVC
  • remove main arguments to silence GCC/Clang in all CMake test projects

Closes #4875

@nlohmann
👷 fix Windows CI
51edad7 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@coveralls
Copy link

coveralls commented Aug 20, 2025 •
edited
Loading

Coverage Status

coverage: 99.191%. remained the same
when pulling 1c5c8d3 on fix-windows
into 4106af8 on develop.

@nlohmann
👷 fix Windows CI
7972801 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
6fdfac0 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
a39c63f 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
2f79aed 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
e5ea307 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
839f816 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
bac3004 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
e38750c 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
cfa3792 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@github-actions github-actions bot added L and removed M labels Aug 21, 2025
@nlohmann
👷 fix Windows CI
ce6ca84 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
017742a 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
babfcf3 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann
👷 fix Windows CI
1c5c8d3 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann marked this pull request as ready for review August 21, 2025 20:05
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Aug 21, 2025
@nlohmann nlohmann added this to the Release 3.12.1 milestone Aug 21, 2025
@nlohmann nlohmann mentioned this pull request Aug 21, 2025
Closed
2 tasks
@nlohmann nlohmann merged commit 4bc4e37 into develop Aug 28, 2025
139 checks passed
@nlohmann nlohmann deleted the fix-windows branch August 28, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI CMake L review needed It would be great if someone could review the proposed changes. tests
Projects
None yet
Milestone
Release 3.12.1
Development

Successfully merging this pull request may close these issues.

Re-enable removed Windows builds
2 participants
@nlohmann @coveralls