fix: ensure progress bars display consistently across all environments #8411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Jul 1, 2025
owlstronaut
force-pushed
the
owlstronaut/progress-fix
branch
from
1434cb3 to
ed0e04b
Compare
|
Ok after a deep dive with boolean tables and everything the logic should be: This will properly short circuit if we are in CI, or if we're not a TTY, and set display appropriately for all 3 conditions. |
owlstronaut
force-pushed
the
owlstronaut/progress-fix
branch
from
ed0e04b to
d2c92fd
Compare
Just pushed for that. So same thing but with shortcut advantage 😄 I'm still not completely convinced it is actually different, lol |
wraithgar
approved these changes
Jul 2, 2025
Merged
reggi
pushed a commit
that referenced
this pull request
Jul 9, 2025
#8411) The progress configuration's default value and runtime behavior now use identical logic, preventing cases where progress bars were unexpectedly disabled in cloud IDEs and other environments. Fixes npm/statusboard#996
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress configuration's default value and runtime behavior now use
identical logic, preventing cases where progress bars were unexpectedly
disabled in cloud IDEs and other environments.
Fixes npm/statusboard#996