[OP#64194] SharePoint UploadLinkQuery #19886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mereghost
force-pushed
the
impl/64194-sp-upload-file
branch
from
331e435 to
949ac90
Compare
Kharonus
requested changes
Aug 13, 2025
...les/storages/app/common/storages/adapters/providers/share_point/queries/upload_link_query.rb
Outdated
Show resolved
Hide resolved
...orages/spec/common/storages/adapters/providers/share_point/queries/upload_link_query_spec.rb
Outdated
Show resolved
Hide resolved
|
|
||
| let(:upload_url) do | ||
| "https://ymt6d.sharepoint.com/sites/OPTest/_api/v2.0/drives/b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY" \ | ||
| "9jo6leJDqrT7muzvmiWjFW/items/01ANJ53W2OGTVJLOZ5R5F2NFJWGJOLV56J/uploadSession?guid=%27ca9855a1-245f-40b" \ |
There was a problem hiding this comment.
🟡 wanna use drive_id as a variable and interpolate it here? Same in the folder_id?
There was a problem hiding this comment.
It might have some value to interpolate the drive id, but folder ID becomes moot point as the API generates the new ID of the upload and returns it as part of the URL, ignoring the parent folder.
There was a problem hiding this comment.
🟡 just a suggestion: maybe to put the token to a file or factory 🤔
| Input::UploadLink.build( | ||
| folder_id: | ||
| "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY8Qconfm2i6SKEoCmuGYqQK||04AZJL5PN6Y2GOVW7725BZO354PWSELRRZ", | ||
| file_name: "DeathStart_blueprints.tiff" |
There was a problem hiding this comment.
Yep it is a blueprint after all. And a TIFF file nonetheless. XD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Work Package: [OP#64194](https://community.openproject.org/projects/marcello-rocha-pereira/work_packages/64194