This repository was archived by the owner on Apr 29, 2025. It is now read-only.
refactor(web/notify): changed useRef to useState to prevent resetting the circle on notifications without an ID and organized the code. #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the circle on notifications without an ID and organized the code. Using useRef causes notifications without an ID to reset the circle duration. Additionally, I've made some improvements and organized the code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
useRefcauses notifications without anIDresets or re-renders the circle duration so i changed it back touseStateto avoid re-rendering. Additionally, I've made some improvements and organized the code.