This repository was archived by the owner on Apr 29, 2025. It is now read-only.
fix(client/vehicleproperties): Reset colors to 0 when changing painttype #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paint type appears to be overridden / ignored depending on what value is passed in for color. By passing in the default `0`, paint type should be respected once the custom rgb is applied.
jag3dagster
commented
Jan 21, 2025
| @@ -348,7 +348,7 @@ function lib.setVehicleProperties(vehicle, props, fixVehicle) | |||
| ClearVehicleCustomPrimaryColour(vehicle) | |||
| SetVehicleColours(vehicle, props.color1 --[[@as number]], colorSecondary --[[@as number]]) | |||
| else | |||
| if props.paintType1 then SetVehicleModColor_1(vehicle, props.paintType1, colorPrimary, pearlescentColor) end | |||
| if props.paintType1 then SetVehicleModColor_1(vehicle, props.paintType1, 0, props.pearlescentColor or pearlescentColor) end | |||
There was a problem hiding this comment.
Potentially will want to actually have the pearl bit be props.pearlescentColor or 0 for a similar reason, but I didn't test that portion too deeply.
There was a problem hiding this comment.
I'll be pushing a new release soon, so let me know if there are other changes.
There was a problem hiding this comment.
I'm away from my pc right now. But I'd recommend the change i mentioned in my other comment if you want to make it before taking the pr
|
@thelindat Updated. Should be good to go now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paint type appears to be overridden / ignored depending on what value is passed in for color. By passing in the default
0, paint type should be respected once the custom rgb is applied.Resolves #598