[gen4] core: fix PSRAM heap size while in safe mode #2871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-brust
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While in safe mode Gen 4 devices only use 32KB of PSRAM for heap. This is not enough.
Solution
Set the minimum PSRAM heap size to 128KB and additionally while in safe mode expand the PSRAM heap to full PSRAM size.
This PR additionally fixes a couple of issues in DCT implementation which doesn't expect e.g. open() calls to fail which leads to RAM and/or flash corruption in case of unexpected issues like being low on heap.
Completeness