Skip to content

Fix bug in presto-router #25043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Fix bug in presto-router #25043

merged 1 commit into from
May 5, 2025

Conversation

aaneja
Copy link
Contributor

@aaneja aaneja commented May 5, 2025

Duration.nanosSince expects a nano time, but a millis time was used.

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@aaneja
Fix bug in presto-router
ff6d733 
Duration.nanosSince expects a nano time, but a millis time
was used.
@aaneja aaneja requested a review from a team as a code owner May 5, 2025 11:44
@aaneja aaneja requested a review from jaystarshot May 5, 2025 11:44
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label May 5, 2025
@prestodb-ci prestodb-ci requested review from a team, anandamideShakyan and auden-woolfson and removed request for a team May 5, 2025 11:44
@aaneja aaneja mentioned this pull request May 5, 2025
Merged
6 tasks
auden-woolfson
auden-woolfson approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@auden-woolfson auden-woolfson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this

@ZacBlanco ZacBlanco merged commit a9a9bae into prestodb:master May 5, 2025
98 checks passed
@aaneja aaneja deleted the bugFixRouter branch May 6, 2025 10:34
@ZacBlanco ZacBlanco mentioned this pull request May 29, 2025
Merged
21 tasks
This was referenced May 30, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacBlanco ZacBlanco ZacBlanco approved these changes

@auden-woolfson auden-woolfson auden-woolfson approved these changes

@jaystarshot jaystarshot Awaiting requested review from jaystarshot jaystarshot is a code owner automatically assigned from prestodb/committers

@anandamideShakyan anandamideShakyan Awaiting requested review from anandamideShakyan anandamideShakyan was automatically assigned from prestodb/ibm-reviewers

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaneja @ZacBlanco @auden-woolfson @prestodb-ci