Skip to content

chore: clean up golangci-lint configuration #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 25, 2025

Description

chore: clean up golangci-lint configuration

@mmorel-35
Copy link
Contributor Author

/cc @kakkoyun @SuperQ

@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch 2 times, most recently from 36bfed7 to 5dda61a Compare April 25, 2025 08:09
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't see any harm on these changes, but I also don't understand why we need these?

This file was generated from the tool itself as a result of running the migrate command.

@mmorel-35
Copy link
Contributor Author

The migration generates useless configuration like exclusion paths my in intention hers is to clean this up and ordering help reading clearly the configuration

@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch 3 times, most recently from 7d1603f to 4b62739 Compare August 1, 2025 21:07
@mmorel-35 mmorel-35 changed the title chore: clean up and sort golangci-lint configuration chore: clean up golangci-lint configuration Aug 1, 2025
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch from 4b62739 to d1d657c Compare August 1, 2025 21:12
@SuperQ SuperQ merged commit 0d1fd88 into prometheus:master Aug 2, 2025
7 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/clean-up branch August 2, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants