Skip to content

Add feature pinch to zoom #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jolojo500
Copy link

This pull reuquest should close #1619 . It adds A class that wraps the activity_main.xml layout, successfully enabling gesture based zooming. It also has smooth transitioning back to the view's original size to not mess with the core and feel of the ui. Was tested on both an emulator and a real device.

Below is a demonstration of it working.
https://github.com/user-attachments/assets/5a03d286-67c8-4b6b-abac-13096a827218

jolojo500 added 4 commits May 9, 2025 22:42
…ol good thing the root is easilly accessible. Works but not the best. WIP2
…orpertyValuesHolder isnt null. ZoomLayout no sbehaves smoothly. Verified the pinch to zoom gesture on real device and works without crashes.This commit should close recloudstream#1619
@fire-light42
Copy link
Collaborator

While I really appreciate this pull request, I meant it more like a pinch-to-zoom like it is on YouTube and not app wide zoom. An app wide zoom can be provided by the operating systems accessibility settings, so I do not believe this implementation is fit for CloudStream. I now see the discussion in the issue, and realize that I misinterpreted the original intent, but see #987 #999

@fire-light42
Copy link
Collaborator

fire-light42 commented May 10, 2025

I believe that you can still continue with this pull request if you move the zoom into the videoplayer xmls, and instead of resetting when releasing only reset when you zoom out (to less then 100%, as no user would want to minimize the app). That way users can set a zoom for a movie without having to hold it. Also, it might be interesting to only allow zoom changes when the videoplayer is not locked,

@jolojo500
Copy link
Author

Alright I will look into it!

@StupidRepo
Copy link

While I really appreciate this pull request, I meant it more like a pinch-to-zoom like it is on YouTube and not app wide zoom. An app wide zoom can be provided by the operating systems accessibility settings, so I do not believe this implementation is fit for CloudStream. I now see the discussion in the issue, and realize that I misinterpreted the original intent, but see #987 #999

Yeah. I mentioned this to them in a reply on the original issue, but I guess they didn't see it: #1619 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pinch-to-zoom
3 participants