-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix(options): Add buffer sizes to failover. Update README #3468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good there are two minor things to change but they are already noted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello @ndyakov , Here's a small suggestion: How about keeping the read/write buffer size of the sentinel client at 4KB? Since there's no need for the sentinel client to handle large data transfers or pipeline scenarios. |
@cxljs great idea! Feel free to work on that or open a separate issue so we can pick it up when possible. |
OK, I'll submit a PR later. |
Fixes #3465