feat(datasource): Add Nextcloud #37292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Aug 13, 2025
| export const ApplicationRelease = z.object({ | ||
| created: z.string(), | ||
| isNightly: z.boolean(), | ||
| translations: z.record(z.string(), Translation), |
There was a problem hiding this comment.
probably use LooseRecord, so it filters Translation with missing changelog and doesn't discard all
|
|
||
| export const Application = z.object({ | ||
| id: z.string(), | ||
| releases: z.array(ApplicationRelease), |
| "customType": "regex", | ||
| "managerFilePatterns": ["/(^|/)renovate.json$/"], | ||
| "matchStrings": [ | ||
| "https://apps.nextcloud.com/api/v1/platform/(?<currentValue>.*)/apps.json" |
There was a problem hiding this comment.
be non-greedy
Suggested change
| "https://apps.nextcloud.com/api/v1/platform/(?<currentValue>.*)/apps.json" | |
| "https://apps.nextcloud.com/api/v1/platform/(?<currentValue>.*?)/apps.json" |
or make even more tight
Suggested change
| "https://apps.nextcloud.com/api/v1/platform/(?<currentValue>.*)/apps.json" | |
| "https://apps.nextcloud.com/api/v1/platform/(?<currentValue>\\d+\\.\\d+\\.\\d+)/apps.json" |
| import { cache } from '../../../util/cache/package/decorator'; | ||
| import { regEx } from '../../../util/regex'; | ||
| import { asTimestamp } from '../../../util/timestamp'; | ||
| import * as semanticVersioning from '../../versioning/semver'; |
There was a problem hiding this comment.
Suggested change
| import * as semanticVersioning from '../../versioning/semver'; | |
| import * as semver from '../../versioning/semver'; |
|
|
||
| static readonly defaultTranslationLanguage = 'en'; | ||
|
|
||
| override readonly defaultVersioning = semanticVersioning.id; |
There was a problem hiding this comment.
Suggested change
| override readonly defaultVersioning = semanticVersioning.id; | |
| override readonly defaultVersioning = semver.id; |
| export class NextcloudDatasource extends Datasource { | ||
| static readonly id = 'nextcloud'; | ||
|
|
||
| static readonly defaultTranslationLanguage = 'en'; |
There was a problem hiding this comment.
Suggested change
| static readonly defaultTranslationLanguage = 'en'; | |
| private static readonly defaultTranslationLanguage = 'en'; |
not externally used, move before public members
|
|
||
| override readonly defaultVersioning = semanticVersioning.id; | ||
|
|
||
| private static readonly sourceUrlRegex = regEx( |
|
|
||
| for (const release of application.releases) { | ||
| const changelogContent = | ||
| release.translations[NextcloudDatasource.defaultTranslationLanguage] |
There was a problem hiding this comment.
what if the translation is missing?
| releaseTimestamp: asTimestamp(release.created), | ||
| changelogContent: | ||
| changelogContent.length > 0 ? changelogContent : undefined, | ||
| changelogUrl: sourceUrlMatches?.groups |
|
|
||
| const result: ReleaseResult = { | ||
| releases: [], | ||
| homepage: application.website, |
There was a problem hiding this comment.
Set sourceUrl if the repo is on github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add Nextcloud data source.
Example PR: bdovaz/renovate_test#20
Readme.mdcustom manager example PR: bdovaz/renovate_test#18Context
#37256
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: