Skip to content

Conversation

defuneste
Copy link
Contributor

Placeholder to merge later:

  • I want to fix get_nbm_release() since they changed a bit their API
  • add back changelog

@defuneste
Copy link
Contributor Author

  • changelog and minor version updated

@defuneste
Copy link
Contributor Author

Will also need to fix this: duckdb/duckdb-r#600 (comment)

@defuneste
Copy link
Contributor Author

Hey @dancingfrog I think I fix some of my issue sadly:

  • devtools::test() is a success

but:

  • devtools::check() are failing the test

Hence we have something different when building the package versus when just runing the test. To investigate.

I will see if "working on my conmputer" is good enough for now!

Waiting to see how the GH runner deal with it!

Copy link
Member

@tech-team-rural-mda tech-team-rural-mda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything is working now

@defuneste
Copy link
Contributor Author

At the end we rewrote the downloading file with a system call to curl instead of using to specifying the user agent in R download.file. The download.file() did not correctly took it correctly (R 4.4 and 4.3). It is less flexible but we run with too many issue with the previous way.

@defuneste defuneste merged commit 6d28263 into main Dec 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants