FEA compat with ipv6 #3301
Closed
FEA compat with ipv6 #3301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxww302
requested review from
merrymercy,
Ying1123,
hnyls2002,
zhyncs,
ispobock and
ByronHsu
as code owners
|
Please apply |
5 tasks
zhaochenyang20
added
good first issue
|
Maybe we should consider adding unit tests for IPv6 to ensure correctness? (it seems that we don't have any yet) |
Merged
|
Thanks for the pr, it seems the problem is on pytorch side pytorch/pytorch#52040 |
merrymercy
requested changes
Mar 17, 2025
| @@ -1006,6 +1006,18 @@ def init_new(server_args, dp_rank: Optional[int] = None) -> "PortArgs": | |||
| # DP attention. Use TCP + port to handle both single-node and multi-node. | |||
| if server_args.nnodes == 1 and server_args.dist_init_addr is None: | |||
| dist_init_addr = ("127.0.0.1", server_args.port + ZMQ_TCP_PORT_DELTA) | |||
| elif server_args.dist_init_addr.startswith("["): # ipv6 address | |||
| # extract host and port from ipv6 address | |||
| addr = server_args.dist_init_addr | |||
There was a problem hiding this comment.
wrap this into a unity function in python/sglang/srt/utils.py
|
Completed in #3949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ADD support for ipv6 dist_init_addr in multi node setting, fix #2892
Modifications
compat with ipv6 in server_args.py
Checklist