-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Split local attention test from fa3 test #5774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
import os | ||
import unittest | ||
from types import SimpleNamespace | ||
|
||
import requests | ||
|
||
from sglang.srt.utils import get_device_sm, kill_process_tree | ||
from sglang.test.few_shot_gsm8k import run_eval as run_eval_few_shot_gsm8k | ||
from sglang.test.test_utils import ( | ||
DEFAULT_MODEL_NAME_FOR_TEST_LOCAL_ATTENTION, | ||
DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH, | ||
DEFAULT_URL_FOR_TEST, | ||
popen_launch_server, | ||
) | ||
|
||
|
||
@unittest.skipIf(get_device_sm() < 90, "Test requires CUDA SM 90 or higher") | ||
class TestFlashAttention3LocalAttn(unittest.TestCase): | ||
model = DEFAULT_MODEL_NAME_FOR_TEST_LOCAL_ATTENTION | ||
base_url = DEFAULT_URL_FOR_TEST | ||
accuracy_threshold = 0.90 | ||
|
||
@classmethod | ||
def get_server_args(cls): | ||
return [ | ||
"--trust-remote-code", | ||
"--cuda-graph-max-bs", | ||
"2", | ||
"--attention-backend", | ||
"fa3", | ||
"--tp", | ||
"4", | ||
"--context-length", | ||
"1000000", | ||
] | ||
|
||
@classmethod | ||
def setUpClass(cls): | ||
# disable deep gemm precompile to make launch server faster | ||
# please don't do this if you want to make your inference workload faster | ||
cls.process = popen_launch_server( | ||
cls.model, | ||
cls.base_url, | ||
timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH, | ||
other_args=cls.get_server_args(), | ||
env=os.environ, | ||
) | ||
|
||
@classmethod | ||
def tearDownClass(cls): | ||
kill_process_tree(cls.process.pid) | ||
|
||
def test_gsm8k(self): | ||
args = SimpleNamespace( | ||
num_shots=4, | ||
num_questions=100, | ||
max_new_tokens=512, | ||
parallel=128, | ||
host="http://127.0.0.1", | ||
port=int(self.base_url.split(":")[-1]), | ||
data_path=None, | ||
) | ||
metrics = run_eval_few_shot_gsm8k(args) | ||
print(f"{metrics=}") | ||
|
||
# Use the appropriate metric key based on the test class | ||
metric_key = "accuracy" | ||
self.assertGreater(metrics[metric_key], self.accuracy_threshold) | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.