-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[router] Update metrics when request completes #7899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ZhangShuaiyi <zhangsy28@lenovo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ZhangShuaiyi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the accuracy of the router's operational metrics. Specifically, it resolves a bug where the sgl_router_running_requests
metric would incorrectly remain non-zero even after all active requests had finished, providing a more reliable real-time representation of the router's workload.
Highlights
- Metric Accuracy Fix: I've addressed an issue where the
sgl_router_running_requests
gauge metric was not being decremented when requests completed. This fix ensures the metric accurately reflects the true number of running requests by updating it upon request completion for both standard and streaming requests.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a bug where the sgl_router_running_requests
metric was not updated when requests complete. The change adds the necessary metric updates for both streaming and non-streaming requests.
My review focuses on a code quality improvement. The logic for updating the metric is duplicated in two places. I've provided a suggestion to refactor this into a shared helper to improve maintainability and prevent potential future inconsistencies. Well done on fixing this bug!
Motivation
Updates
sgl_router_running_requests
when request completes.sglang.bench_serving:
Behavior before this change:
The metric
sgl_router_running_requests
was only updated inselect_generate_worker_from_text
. Whensglang.bench_serving
finishes, the router logs show no running queuesBut
sgl_router_running_requests
in the metrics remains non-zero.Behavior after this change:
The
sgl_router_running_requests
metric now correctly drops to zero.Modifications
Checklist