Skip to content

ENH When model file is empty, warn before upload #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 23, 2022
Merged

ENH When model file is empty, warn before upload #109

merged 5 commits into from
Aug 23, 2022

Conversation

BenjaminBossan
Copy link
Collaborator

Fixes #41

@BenjaminBossan
Copy link
Collaborator Author

Ready for review @skops-dev/maintainers

adrinjalali
adrinjalali reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the nits on the messages (but they're missing a dot at the end).

BenjaminBossan and others added 2 commits August 23, 2022 10:36
@BenjaminBossan @adrinjalali
Reviewer comment: Error message
52c0631 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@BenjaminBossan @adrinjalali
Reviewer comment: Error message
403ee2d 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@BenjaminBossan
Copy link
Collaborator Author

I committed your suggestions.

but they're missing a dot at the end

I'm never sure about this one, error messages both with and without dot are used commonly.

@adrinjalali adrinjalali changed the title When model file is empty, warn before upload ENH When model file is empty, warn before upload Aug 23, 2022
@adrinjalali adrinjalali merged commit 7ddb651 into skops-dev:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn users if the provided pickle file is empty
2 participants
@BenjaminBossan @adrinjalali