ENH add implementation for init and push #12
Conversation
adrinjalali
changed the title
|
@merveenoyan this should be ready for a review :) |
examples/plot_hf_hub.py
Outdated
| HfApi().create_repo(repo_id=repo_name, token=token, repo_type="model") | ||
|
|
There was a problem hiding this comment.
Do we want to include this inside Hub functionalities in later versions?
There was a problem hiding this comment.
What do you mean? I'm not sure what "Hub functionality" refers to here. What would the users' code look like with what you're thinking?
There was a problem hiding this comment.
I'd expect the pushing function to create the repository if it doesn't exist.
There was a problem hiding this comment.
Ok. 84c8903 adds a create_remote parameter to allow the user to do that.
| create_remote: bool, optional | ||
| Whether to create the remote repository if it doesn't exist. If the | ||
| remote repository doesn't exist and this parameter is ``False``, it | ||
| raises an error. Otherwise it checks if the remote repository exists, | ||
| and would create it if it doesn't. |
There was a problem hiding this comment.
If this exists, why do we create_repo in examples and tests? Wouldn't it cause confusion?
There was a problem hiding this comment.
I've removed it from the example, but the test needs to test different scenarios, and the user might create the repo before calling this method, so the test makes sure that case is tested as well.
| path_in_repo=".", | ||
| folder_path=source, | ||
| commit_message=commit_message, | ||
| commit_description=None, |
There was a problem hiding this comment.
Why is this needed? 😅
There was a problem hiding this comment.
For now I'm not exposing this to the end user, but passing it here. Passing it explicitly means if huggingface_hub decides to change the default value of this parameter, our users wouldn't notice anything cause we're already explicitly setting it anyway.
| commit_message=commit_message, | ||
| commit_description=None, | ||
| token=token, | ||
| repo_type=None, |
There was a problem hiding this comment.
This is by default None and None refers to model BTW
There was a problem hiding this comment.
Yes, same as above, I'm just explicitly setting it in case in the future the default value changes.
Add implementation for
initandpush.