Skip to content

Conversation

adrinjalali
Copy link
Member

This should fix the mypy issue for now.

@adrinjalali
Copy link
Member Author

CI is green here.

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have hoped for a quick mypy release to address the error. But probably we should pin for now. We just have to make sure to observe the issue and unpin if it is resolved.

@adrinjalali
Copy link
Member Author

The issue doesn't even say the fix will be included in the coming release, it might come in the one after, so I think we should pin for now. I still haven't been sold on the idea of mypy lol.

@BenjaminBossan BenjaminBossan merged commit 913146d into skops-dev:main Sep 15, 2022
@adrinjalali adrinjalali deleted the mypy branch September 15, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants