TST Refactor: clean persistence tests to avoid duplicate testing #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Bossan <benjamin.bossan@gmail.com>
|
@skops-dev/maintainers ready for review |
adrinjalali
reviewed
Oct 25, 2022
| return self | ||
|
|
||
|
|
||
| def test_dump_to_and_load_from_disk(tmp_path): |
There was a problem hiding this comment.
maybe as an alternative, or another test, we could save/load from disk and memory, and compare the objects' hashes to make sure they're the same?
There was a problem hiding this comment.
Yes, I can add another test. To be sure I understand correctly, you mean comparing the hashes of both objects in memory, one obtained through dump/load and one for dumps/loads? If so, what method would you use to hash them, joblib.hash?
adrinjalali
approved these changes
Oct 25, 2022
adrinjalali
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #198
After introducing
dumpsandloads, we ran all persistence tests twice, once with those functions and once withdumpandload. This is inefficient, since they're basically testing the same thing but running 400+ tests twice is costly. With this PR, we only use the more efficientdumpsandloads. On top of that, there is one test that very specifically testsdumpandload.