-
Notifications
You must be signed in to change notification settings - Fork 60
FEAT Parse model cards with pandoc #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adrinjalali
merged 54 commits into
skops-dev:main
from
BenjaminBossan:parse-model-cards-pandoc
Jan 24, 2023
Merged
Changes from 41 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
faf9e37
[skip ci] [WIP] Alternative Card implementation
BenjaminBossan cc229a2
[WIP] Further align new model card design
BenjaminBossan 166e33d
Make tests pass
BenjaminBossan a90e3a5
Add tests for new functionalities and docstrings
BenjaminBossan fcbd0df
Adjust tests to work with older sklearn versions
BenjaminBossan 4f10f80
Adjust examples to new card, more docs
BenjaminBossan 0f5df2e
Continue fixing tests
BenjaminBossan 6212d67
Try fixing Windows error by specifying encoding
BenjaminBossan 80d218d
Adjust doctest: confusion matrix not stored in cwd
BenjaminBossan c6c8042
Increase test coverage
BenjaminBossan e7a2ae3
Try fixing test failure on Windows
BenjaminBossan 2a6aab0
Replace old by new Card implementation
BenjaminBossan ce16019
Merge branch 'main' into alternative-model-card-implementation
BenjaminBossan 00b7665
Address reviewer comments
BenjaminBossan 8558f26
Add TODO notes for when Python 3.7 is dropped
BenjaminBossan fdb7674
Add Hub model card template, add template arg
BenjaminBossan 772a659
Make _add_single return the Section
BenjaminBossan 7cfddf9
Allow tables without rows to be added
BenjaminBossan 50b0d39
Parser that allows to load dumped model cards
BenjaminBossan 26892d6
Error when calling add_metric w/ invalid template
BenjaminBossan 9646103
Merge branch 'alternative-model-card-implementation' into parse-model…
BenjaminBossan 80a4ae3
Support model cards with yaml header
BenjaminBossan 9744998
Add a bunch of more markup support
BenjaminBossan d864941
Add more test cases for model card parser
BenjaminBossan 5e5c1a3
Rename Markdown class's methods, make private
BenjaminBossan 1ff15be
Merge branch 'main' into parse-model-cards-pandoc
BenjaminBossan 8979751
Add version check for pandoc
BenjaminBossan e8d6f61
New table parsing code
BenjaminBossan d0e07bc
Fix "bug" with metainfo order
BenjaminBossan 5a9f826
Clean up noise created from merge conflict
BenjaminBossan 5bc5909
Fix TypedDict import for Py<3.9, doctest
BenjaminBossan 3c3ff89
Add future annotations import to _markup.py
BenjaminBossan c2ccfcc
Add more documentation, refactor parser class
BenjaminBossan a2f90a4
Skip parts of parse_modelcard docstring test
BenjaminBossan de454cc
Merge branch 'main' into parse-model-cards-pandoc
BenjaminBossan 7ececc1
Increase test coverage, add a few features
BenjaminBossan 08505f9
Install pandoc on linux CI to test parser
BenjaminBossan d0aa9df
Add documentation about parsing model cards
BenjaminBossan 5da3397
Fix incorrect link in docs
BenjaminBossan 2cb998e
Clean up test_parser.py
BenjaminBossan 1922bc1
Move changes entry to v0.5
BenjaminBossan e684c78
Merge branch 'main' into parse-model-cards-pandoc
BenjaminBossan 709e079
Reviewer comments: wording, period in err msg
BenjaminBossan 08f44c4
Use packaging Version for version comparison
BenjaminBossan 7c416c4
Install pandoc with apt in CI
BenjaminBossan b855e50
Investigate pandoc version issue
BenjaminBossan 2da5ea6
Lower min required pandoc version to 2.9.0
BenjaminBossan 6d1f288
Revert pandoc install to use gh + deb
BenjaminBossan d6d8e0a
Merge branch 'main' into parse-model-cards-pandoc
BenjaminBossan fb46a76
Add Figure type to parsing
BenjaminBossan 04c5756
Merge branch 'main' into parse-model-cards-pandoc
BenjaminBossan 30d3e5c
Add pragmas for lines that are covered
BenjaminBossan de1837e
Add more unit tests, get to 100% coverage
BenjaminBossan 6472ebf
Fix incorrect docstring
BenjaminBossan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
from ._model_card import Card, metadata_from_config | ||
from ._parser import parse_modelcard | ||
|
||
__all__ = ["Card", "metadata_from_config"] | ||
__all__ = ["Card", "metadata_from_config", "parse_modelcard"] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.