-
Notifications
You must be signed in to change notification settings - Fork 60
ENH
Allow collapsing any section in card
#341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BenjaminBossan
merged 11 commits into
skops-dev:main
from
lazarust:ENH-allow-folding-any-section
Jun 1, 2023
+60
−2
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
62242b2
Updates Section class and adds test stub
lazarust 54d15a2
Merge branch 'main' into ENH-allow-folding-any-section
lazarust 81b3a5a
Removes getter and setter and added `set_folded` instead.
lazarust 94874c9
Merge branch 'main' into ENH-allow-folding-any-section
lazarust 60496e7
Merge branch 'main' into ENH-allow-folding-any-section
lazarust 5491b53
WIP Doesn't change child sections folded attribute
lazarust 390e31c
Merge branch 'main' into ENH-allow-folding-any-section
lazarust 15ad2fa
Updates test to check if folded
lazarust 427dc53
Updates test and adds documentation
lazarust bc93a3d
Fixes sphinx documentation
lazarust d3a7b6d
Updated documentation
lazarust File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this last line is not necessary. Instead, it would be better to describe what effect this has on the final model card (not every reader will be familiar with what "folding" means).