FIX use rich.tree instead of rich.print #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed a few things, but it seems the remaining two failing tests are legit? |
|
I’ll have a look. I’ll also try to test a couple of stuff if possible.
Guillaume Lemaitre
Open source engineer at :probabl.
…On Thu 6 Mar 2025 at 09:16, Adrin Jalali ***@***.***> wrote:
I fixed a few things, but it seems the remaining two failing tests are
legit?
—
Reply to this email directly, view it on GitHub
<#472 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY32P7FIJ2KU66CWSYCDH32S774LAVCNFSM6AAAAABYNCHGI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBTGEZDANBZHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: adrinjalali]*adrinjalali* left a comment (skops-dev/skops#472)
<#472 (comment)>
I fixed a few things, but it seems the remaining two failing tests are
legit?
—
Reply to this email directly, view it on GitHub
<#472 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY32P7FIJ2KU66CWSYCDH32S774LAVCNFSM6AAAAABYNCHGI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBTGEZDANBZHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
adrinjalali
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
richtree visualization.It also using some colorblind color scheme: cyan / orange1 / magenta