Skip to content

Conversation

jim4067
Copy link
Contributor

@jim4067 jim4067 commented Mar 20, 2025

No description provided.

Copy link

vercel bot commented Mar 20, 2025

@jim4067 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added the documentation Improvements or additions to documentation label Mar 20, 2025
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this PR, but these links are unmaintainable (independent of your changes). It makes it difficult to bump versions because we can't just replace the old version with the new version, as links could break.

I already mentioned this problem to @ZYJLiu and said we should move to permalinks instead of linking tags. Would you be interested in doing that? For example:

-[`CpiContext`](https://github.com/coral-xyz/anchor/blob/v0.31.0/lang/src/context.rs#L171),
+[`CpiContext`](https://github.com/coral-xyz/anchor/blob/0e5285aecdf410fa0779b7cd09a47f235882c156/lang/src/context.rs#L171),

@jim4067
Copy link
Contributor Author

jim4067 commented Mar 20, 2025

Lemme do that instead

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@acheroncrypto acheroncrypto merged commit b8ee933 into solana-foundation:master Mar 22, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants