fix(dui3): cleans up base layer prefix from invalid chars - fixes second receive cleanup issues #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ond receive cleanup issues and adds extra defensibility around layer naming in acad.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #101 +/- ##
=====================================
Coverage 8.26% 8.26%
=====================================
Files 230 230
Lines 4358 4358
Branches 503 503
=====================================
Hits 360 360
Misses 3988 3988
Partials 10 10 ☔ View full report in Codecov by Sentry. |
i have no idea how i even wrote this code in the first place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and adds extra defensibility around layer naming in acad.
The issue was that we were not consistently cleaning up the base layer prefix:
/chars/charsresulting in all second receives from nested models being borked.
Also fixes another acad second receive bug, where we would stop purging object layers if we would encounter one with no objects on it.