Feat(dui3) Debouncing progress updates #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #106 +/- ##
========================================
- Coverage 8.24% 8.21% -0.04%
========================================
Files 230 231 +1
Lines 4367 4383 +16
Branches 505 508 +3
========================================
Hits 360 360
- Misses 3997 4013 +16
Partials 10 10 ☔ View full report in Codecov by Sentry. |
adamhathcock
requested changes
Aug 6, 2024
| /// Debouncing progress for every %1 update for UI. | ||
| /// This class requires a specific bridge in its binding, so registering it will create random bridge which we don't want to. | ||
| /// </summary> | ||
| public class OperationProgressManager |
There was a problem hiding this comment.
I would make this class a singleton and inject it on usage. The Bridge isn't needed until set is called so doesn't need to be on the constructor.
How does it know it's done? Does the diff only care if it's changed, not if it's greater?
* uses time instead of progress values * adds status as a change detector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial attempt was on Timers, but I had random behaviors on Autocad, then decided to go with percentage difference checks. Since we round decimals on UI, we don't need to send progress updates less than %1. OperationProgressManager handles it with concurrent dictionary. Open to suggestions, I might do more tests before merging it.