Dimitrie/cnx 201 group names from autocad to rhino are not supported #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set always note, this means we're using our naming hack again
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #126 +/- ##
=====================================
Coverage 8.21% 8.21%
=====================================
Files 232 232
Lines 4382 4382
Branches 498 498
=====================================
Hits 360 360
Misses 4012 4012
Partials 10 10 ☔ View full report in Codecov by Sentry. |
didimitrie
deleted the
dimitrie/cnx-201-group-names-from-autocad-to-rhino-are-not-supported
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes group creation so they are correctly named; this required purging previously created groups for second receive workflows. I've taken the chance to also move a lot of the group creation logic outside of the host object builder to the group manager itself, though IIRC the group manager was meant to be split into group unpacker and group baker, but it got merged into one in the last PR on render materials.
See CNX-201 for full details of the issue.
Proof it works for Bilal:
.