fix(acad): fatal crash on highlight

[didimitrie]

cause: we were creating definition instances with no objects inside of them, and this was causing acad to throw later down the line on highlighting.

fixed by:

• catching the exception for null geometric extents in the highlight logic
• throwing conversion exceptions when creating instances if object count === 0

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

• My pull request follows the guidelines in the Contributing guide?
• My pull request does not duplicate any other open Pull Requests for the same update/change?
• My commits are related to the pull request and do not amend unrelated code or documentation.
• My code follows a similar style to existing code.
• I have added appropriate tests.
• I have updated or added relevant documentation.

References

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.20%. Comparing base (6fb4081) to head (b36c866).

Additional details and impacted files

@@          Coverage Diff          @@
##             dev    #130   +/-   ##
=====================================
  Coverage   8.20%   8.20%           
=====================================
  Files        233     233           
  Lines       4389    4389           
  Branches     503     503           
=====================================
  Hits         360     360           
  Misses      4019    4019           
  Partials      10      10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.