CXPLA-17 Add XX_OR_GREATER flags to converter/connector projects #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #136 +/- ##
=====================================
Coverage 8.19% 8.19%
=====================================
Files 233 233
Lines 4391 4391
Branches 503 503
=====================================
Hits 360 360
Misses 4021 4021
Partials 10 10 ☔ View full report in Codecov by Sentry. |
JR-Morgan
reviewed
Aug 12, 2024
| @@ -3,6 +3,7 @@ | |||
| <PropertyGroup> | |||
| <TargetFramework>net48</TargetFramework> | |||
| <PlatformTarget>x64</PlatformTarget> | |||
| <DefineConstants>$(DefineConstants);CIVIL3D;CIVIL3D2024;CIVIL3D2024_OR_GREATER</DefineConstants> | |||
There was a problem hiding this comment.
Guessing we should have CIVIL3D2023_OR_GREATER here too?
Tho, not sure the status of our CIVIL versions... if we don't have other versions yet, then we should just remember to correct the DefineConstants later
JR-Morgan
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds XX_OR_GREATER to all converter and connector projects:
Left ArcGIS out because it has no other version, so it's intention is not as clear.