Skip to content

Conversation

JR-Morgan
Copy link
Member

in specklesystems/speckle-sharp-sdk#68, We updated Operations.Send to return the required references.
In this PR, I've updated connectors to use this instead of the older SendHelper

We may decide later to bring back a Sender service instead of using statics, but we need to plan this as a larger restructure of our Sdks.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 8.31%. Comparing base (db60e3e) to head (72da82b).

Files Patch % Lines
...le.Connectors.Utils/Operations/RootObjectSender.cs 0.00% 2 Missing ⚠️
...onnectors.Utils/Caching/NullSendConversionCache.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #140      +/-   ##
========================================
+ Coverage   8.19%   8.31%   +0.11%     
========================================
  Files        233     232       -1     
  Lines       4391    4332      -59     
  Branches     503     491      -12     
========================================
  Hits         360     360              
+ Misses      4021    3962      -59     
  Partials      10      10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan marked this pull request as ready for review August 13, 2024 10:42
@JR-Morgan JR-Morgan requested a review from didimitrie August 13, 2024 10:42
@JR-Morgan JR-Morgan enabled auto-merge (squash) August 13, 2024 11:04
@JR-Morgan JR-Morgan merged commit d25272f into dev Aug 13, 2024
3 checks passed
@JR-Morgan JR-Morgan deleted the jrm/bump-deps-send branch August 13, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants