Skip to content

Conversation

didimitrie
Copy link
Member

@didimitrie didimitrie commented Aug 13, 2024

Several things:

  • Cleans up root object builder a bit in revit. Had potential to get messy.
  • Fully cleans up hosted element convertor

…onManager

to cleanup the root object builder
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 8.31%. Comparing base (d25272f) to head (85d28db).

Files Patch % Lines
...ckle/TopLevel/ElementTopLevelConverterToSpeckle.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #142   +/-   ##
=====================================
  Coverage   8.31%   8.31%           
=====================================
  Files        232     232           
  Lines       4332    4332           
  Branches     491     491           
=====================================
  Hits         360     360           
  Misses      3962    3962           
  Partials      10      10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@oguzhankoral oguzhankoral enabled auto-merge (squash) August 13, 2024 11:28
@oguzhankoral oguzhankoral merged commit 4e220db into dev Aug 13, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the dim/revit branch August 13, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants