-
Notifications
You must be signed in to change notification settings - Fork 27
Agis colors receive #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agis colors receive #147
Conversation
needs more commits to test |
color = objColor; | ||
// POC: should we get the color of the closest parent and break, or walk up to the highest possible? | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we get the color of the closest parent, or the highest in the hierarchy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand the question here: if the atomic object doesn't have a color, then the color of the closest parent with a color should be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's resolve this POC comment before merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #147 +/- ##
=====================================
Coverage 8.61% 8.61%
=====================================
Files 236 236
Lines 4468 4468
Branches 525 525
=====================================
Hits 385 385
Misses 4066 4066
Partials 17 17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did some testing receiving from rhino, looks good!
However, receiving render material proxies should exist as well, for receiving from applications where no colors are being sent (eg revit).
This logic could just check for ["colorProxies"] on the base collection, if none exist, check for ["renderMaterialProxies"] instead and use those values.
Receive ColorProxies in ArcGIS: