Skip to content

Conversation

KatKatKateryna
Copy link
Contributor

Receive ColorProxies in ArcGIS:

  • create UniqueRenderer for every Feature Layer
  • create unique color groups for each object in the layer, associate color with Speckle_ID
  • if colorProxy not found for the object, check if any of the object parents has the color assigned and apply it.

@KatKatKateryna
Copy link
Contributor Author

needs more commits to test

color = objColor;
// POC: should we get the color of the closest parent and break, or walk up to the highest possible?
break;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get the color of the closest parent, or the highest in the hierarchy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the question here: if the atomic object doesn't have a color, then the color of the closest parent with a color should be used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve this POC comment before merge

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.61%. Comparing base (cd3944c) to head (5f5fc93).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #147   +/-   ##
=====================================
  Coverage   8.61%   8.61%           
=====================================
  Files        236     236           
  Lines       4468    4468           
  Branches     525     525           
=====================================
  Hits         385     385           
  Misses      4066    4066           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clairekuang
clairekuang previously approved these changes Aug 15, 2024
Copy link
Member

@clairekuang clairekuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did some testing receiving from rhino, looks good!
However, receiving render material proxies should exist as well, for receiving from applications where no colors are being sent (eg revit).
This logic could just check for ["colorProxies"] on the base collection, if none exist, check for ["renderMaterialProxies"] instead and use those values.

@clairekuang clairekuang enabled auto-merge (squash) August 15, 2024 15:13
@clairekuang clairekuang merged commit 58e7c1a into dev Aug 15, 2024
3 checks passed
@clairekuang clairekuang deleted the AGIS-colors-receive branch August 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants