Skip to content

Conversation

adamhathcock
Copy link
Member

Copy link

linear bot commented Aug 14, 2024

@adamhathcock adamhathcock marked this pull request as ready for review August 15, 2024 09:23
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 100 lines in your changes missing coverage. Please review.

Project coverage is 8.63%. Comparing base (b9411f4) to head (4955c8f).
Report is 5 commits behind head on dev.

Files Patch % Lines
...le.Connectors.Utils/Operations/RootObjectSender.cs 0.00% 46 Missing ⚠️
...le.Connectors.Utils/Operations/ReceiveOperation.cs 0.00% 31 Missing ⚠️
...nectors.Utils/Operations/ProgressDisplayManager.cs 43.75% 11 Missing and 7 partials ⚠️
...le.Connectors.Utils/Operations/StopwatchManager.cs 0.00% 4 Missing ⚠️
.../Speckle.Connectors.Utils/ContainerRegistration.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #151      +/-   ##
========================================
+ Coverage   8.29%   8.63%   +0.33%     
========================================
  Files        233     236       +3     
  Lines       4338    4459     +121     
  Branches     492     525      +33     
========================================
+ Hits         360     385      +25     
- Misses      3968    4057      +89     
- Partials      10      17       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@adamhathcock adamhathcock enabled auto-merge (squash) August 15, 2024 10:42
@adamhathcock adamhathcock merged commit be572a2 into dev Aug 15, 2024
3 checks passed
@adamhathcock adamhathcock deleted the adam/cxpla-25-surface-up-in-the-ui-mbs-or-equivalent-metric-from branch August 15, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants