Skip to content

Rhino send binding fixes #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Rhino send binding fixes #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7648a5d
Rhino send binding fixes
JR-Morgan Aug 15, 2024
d55870f
Added Send settings to ISendBinding
JR-Morgan Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Connectors/ArcGIS/Speckle.Connectors.ArcGIS3/Bindings/ArcGISSendBinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ private void GetIdsForMapMemberPropertiesChangedEvent(MapMemberPropertiesChanged

public List<ISendFilter> GetSendFilters() => _sendFilters;

public List<CardSetting> GetSendSettings => [];
public List<CardSetting> GetSendSettings() => [];

[SuppressMessage(
"Maintainability",
Expand Down
2 changes: 1 addition & 1 deletion Connectors/Autocad/Speckle.Connectors.AutocadShared/Bindings/AutocadSendBinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ private void RunExpirationChecks()

public List<ISendFilter> GetSendFilters() => _sendFilters;

public List<CardSetting> GetSendSettings => [];
public List<CardSetting> GetSendSettings() => [];

public Task Send(string modelCardId)
{
Expand Down
7 changes: 1 addition & 6 deletions Connectors/Rhino/Speckle.Connectors.RhinoShared/Bindings/RhinoSendBinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,6 @@ ILogger<RhinoSendBinding> logger

private void SubscribeToRhinoEvents()
{
RhinoDoc.LayerTableEvent += (_, _) =>
{
Commands.RefreshSendFilters();
};

Command.BeginCommand += (_, e) =>
{
if (e.CommandEnglishName == "BlockEdit")
Expand Down Expand Up @@ -150,7 +145,7 @@ private void SubscribeToRhinoEvents()

public List<ISendFilter> GetSendFilters() => _sendFilters;

public List<CardSetting> GetSendSettings => [];
public List<CardSetting> GetSendSettings() => [];

public async Task Send(string modelCardId)
{
Expand Down
3 changes: 3 additions & 0 deletions DUI3/Speckle.Connectors.DUI/Bindings/ISendBinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
using Speckle.Connectors.DUI.Models.Card.SendFilter;
using Speckle.Connectors.DUI.Settings;

namespace Speckle.Connectors.DUI.Bindings;

public interface ISendBinding : IBinding
{
public List<ISendFilter> GetSendFilters();

public List<CardSetting> GetSendSettings();

/// <summary>
/// Instructs the host app to start sending this model.
/// </summary>
Expand Down
Loading