feat(revit): CNX-188 extract material quantities out for all objects #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-for-all-objects-regardless
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #184 +/- ##
========================================
- Coverage 8.44% 8.28% -0.16%
========================================
Files 238 239 +1
Lines 4597 4685 +88
Branches 516 534 +18
========================================
Hits 388 388
- Misses 4192 4280 +88
Partials 17 17 ☔ View full report in Codecov by Sentry. |
…t-for-all-objects-regardless
…t-for-all-objects-regardless
…t-for-all-objects-regardless
Converters/Revit/Speckle.Converters.RevitShared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs
Outdated
Show resolved
Hide resolved
…t-for-all-objects-regardless
* combines material and render material conversion and removes bad logic * simplifies caching logic * minor notes
…t-for-all-objects-regardless
…d converter & fixes a copy paste error
we can bring 'em back if we validate the need for them.
…t-for-all-objects-regardless
…objects-regardless' of https://github.com/specklesystems/speckle-sharp-connectors into claire/cnx-188-extract-material-quantities-out-for-all-objects-regardless
didimitrie
previously approved these changes
Aug 26, 2024
| _materialCacheSingleton = materialCacheSingleton; | ||
| } | ||
|
|
||
| public RevitMaterial Convert(DB.Material target) |
There was a problem hiding this comment.
I somehow feel we need to cleanup a bit what's happening - the trigger is we're shuffling in visual display stuff
…t-for-all-objects-regardless
oguzhankoral
requested changes
Aug 26, 2024
Comment on lines
69
to
70
| private readonly RevitMaterialCacheSingleton _materialCacheSingleton; | ||
| private readonly DisplayValueExtractor _displayValueExtractor; |
There was a problem hiding this comment.
seems like these dudes shouldn't be injected at all
Comment on lines
23
to
27
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| /// <param name="target"></param> | ||
| /// <returns></returns> |
There was a problem hiding this comment.
nice doc
jokes aside, it might be good to explain why it is list of dict as key string as value object?
oguzhankoral
approved these changes
Aug 26, 2024
didimitrie
deleted the
claire/cnx-188-extract-material-quantities-out-for-all-objects-regardless
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds material quantities to all revit objects. Smaple commit: https://app.speckle.systems/projects/93200a735d/models/1b29238359@ae1b38c9aa
This is done by mirroring behavior in V2, by:
Also fixes a bug from display value extractor for lighting fixtures that was preventing commits from being sent.
However, for post-september release we should seriously consider sending
MaterialProxiesinstead of attached the material to every material quantity. Need to validate how this affect data workflows in powerbi, viewer, and excel.