Skip to content

Fix(rhino): Do not store group id in baked object ids #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix(rhino): Do not store group id in baked object ids #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Connectors/Rhino/Speckle.Connectors.RhinoShared/Bindings/RhinoBasicConnectorBinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ private void HighlightObjectsOnView(IReadOnlyList<RhinoObject> rhinoObjects, IRe
RhinoDoc.ActiveDoc.Objects.UnselectAll();
List<RhinoObject> rhinoObjectsToSelect = new(rhinoObjects);

foreach (Group group in groups)
foreach (Group group in groups) // This is not performant if we have many groups. That's why we do not store group ids on baked object ids, to not have a problem later on highlighting all model. Mostly for single group highlight from report item.
{
int groupIndex = RhinoDoc.ActiveDoc.Groups.Find(group.Name);
if (groupIndex < 0)
Expand Down
4 changes: 2 additions & 2 deletions Connectors/Rhino/Speckle.Connectors.RhinoShared/Operations/Receive/RhinoHostObjectBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,9 @@ private HostObjectBuilderResult BakeObjects(
}

// 4: log
var id = conversionIds[0];
var id = conversionIds[0]; // this is group id if it is a one to many conversion, otherwise id of object itself
conversionResults.Add(new(Status.SUCCESS, obj, id, result.GetType().ToString()));
bakedObjectIds.Add(id);
bakedObjectIds.AddRange(conversionIds.Skip(1)); // first item always a group id, which we do not want to deal with later groups and its sub elements. It causes a huge issue on performance.

// 5: populate app id map
applicationIdMap[obj.applicationId ?? obj.id] = conversionIds;
Expand Down
Loading