Skip to content

Conversation

oguzhankoral
Copy link
Member

@oguzhankoral oguzhankoral commented Aug 23, 2024

I registered settings per unit of work by passing exact instance always at the beginning of resolve. We need brand new ToSpeckleSettings per unit of work that generated with info on model card per operation.

Invalidates the cache if the DetailLevelType has changed

ht to @AlanRynne

COARSE
chrome_CcGmsgCwol

MEDIUM
chrome_l34kVT2mF9

FINE
B8cYrbVb0T

Copy link

linear bot commented Aug 23, 2024

@oguzhankoral oguzhankoral marked this pull request as draft August 23, 2024 08:44
@oguzhankoral oguzhankoral changed the title Feat(Settings): revit settings for geometry details and project base point Feat(Settings): revit settings for geometry details Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 8.44%. Comparing base (dc23b80) to head (eb7a66c).
Report is 1 commits behind head on dev.

Files Patch % Lines
...rters.RevitShared/Helpers/DisplayValueExtractor.cs 0.00% 14 Missing ⚠️
...RevitShared/Helpers/RevitConversionContextStack.cs 0.00% 1 Missing ⚠️
...nverters.RevitShared/Settings/ToSpeckleSettings.cs 0.00% 1 Missing ⚠️
...e.Autofac/DependencyInjection/UnitOfWorkFactory.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #195      +/-   ##
========================================
- Coverage   8.46%   8.44%   -0.03%     
========================================
  Files        237     238       +1     
  Lines       4583    4597      +14     
  Branches     516     516              
========================================
  Hits         388     388              
- Misses      4178    4192      +14     
  Partials      17      17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oguzhankoral oguzhankoral requested a review from AlanRynne August 23, 2024 08:48
@oguzhankoral oguzhankoral marked this pull request as ready for review August 23, 2024 09:12
@oguzhankoral oguzhankoral changed the title Feat(Settings): revit settings for geometry details Feat(Settings): revit settings passes to converter Aug 23, 2024
@didimitrie didimitrie merged commit 953ffcc into dev Aug 23, 2024
5 checks passed
@didimitrie didimitrie deleted the oguzhan/cnx-289-revit-settings-for-geometry-details-and-project-base-point branch August 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants