Fix(revit): regression on switching ElementId to UniqueId #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #202 +/- ##
=====================================
Coverage 8.28% 8.28%
=====================================
Files 239 239
Lines 4683 4683
Branches 537 537
=====================================
Hits 388 388
Misses 4279 4279
Partials 16 16 ☔ View full report in Codecov by Sentry. |
didimitrie
requested changes
Aug 26, 2024
Connectors/Revit/Speckle.Connectors.RevitShared/ElementIdHelper.cs
Outdated
Show resolved
Hide resolved
Connectors/Revit/Speckle.Connectors.RevitShared/Bindings/RevitSendBinding.cs
Outdated
Show resolved
Hide resolved
didimitrie
approved these changes
Aug 27, 2024
oguzhankoral
deleted the
oguzhan/cnx-376-revit-cant-highlight-elements-from-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a regression on switch from ElementId to UniqueId, since we send report items as UniqueId, it can't parse them directly to ElementId