Fix(revit): Reference to CefSharp.Wpf.NETCore for Revit 2025 #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #204 +/- ##
=====================================
Coverage 8.28% 8.28%
=====================================
Files 239 239
Lines 4683 4683
Branches 537 537
=====================================
Hits 388 388
Misses 4279 4279
Partials 16 16 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR > Moved from WebView2 to CefSharp.Wpf.NETCore for Revit 2025
Reviewer should test too!
Since the thread management is different between WebView2 and CefSharp, Revit UI was freezing in 2025 bc we moved to WebView2 with it. The source of the problem was we were running SendOperation with
RevitTask.RunAsyncto prevent randomAccessMemoryVialoationexceptions. And running the operation withRevitTask.RunAsyncwas freezing Revit UI with WebView2.Thanks to @JR-Morgan and @didimitrie for live fixing effort!