-
Notifications
You must be signed in to change notification settings - Fork 27
fix(revit): CNX-394 better reference point cache invalidation #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
oguzhankoral
merged 20 commits into
dev
from
claire/cnx-340-send-reference-and-survey-point-on-revit-root-collection
Aug 30, 2024
Merged
fix(revit): CNX-394 better reference point cache invalidation #213
oguzhankoral
merged 20 commits into
dev
from
claire/cnx-340-send-reference-and-survey-point-on-revit-root-collection
Aug 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-on-revit-root-collection
…t-on-revit-root-collection
…-root-collection' of https://github.com/specklesystems/speckle-sharp-connectors into claire/cnx-340-send-reference-and-survey-point-on-revit-root-collection
…t-on-revit-root-collection
…t-on-revit-root-collection
…sform to meshlist conversion
…t-on-revit-root-collection
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #213 +/- ##
=====================================
Coverage 7.49% 7.49%
=====================================
Files 237 237
Lines 4604 4603 -1
Branches 534 534
=====================================
Hits 345 345
+ Misses 4244 4243 -1
Partials 15 15 ☔ View full report in Codecov by Sentry. |
oguzhankoral
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference point pr was caching the setting, and invalidating cached objects only if setting has changed. Since it is the transform that determines whether or not we need to reconvert objects, now we are tracking the reference point transform instead of the setting enum . This is because users can change the reference point between send operations, resulting in a changed transform even though the reference point enum remains the same.