Skip to content

Conversation

clairekuang
Copy link
Member

@clairekuang clairekuang commented Aug 30, 2024

Reference point pr was caching the setting, and invalidating cached objects only if setting has changed. Since it is the transform that determines whether or not we need to reconvert objects, now we are tracking the reference point transform instead of the setting enum . This is because users can change the reference point between send operations, resulting in a changed transform even though the reference point enum remains the same.

Copy link

linear bot commented Aug 30, 2024

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.49%. Comparing base (6b7574e) to head (4b388ec).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #213   +/-   ##
=====================================
  Coverage   7.49%   7.49%           
=====================================
  Files        237     237           
  Lines       4604    4603    -1     
  Branches     534     534           
=====================================
  Hits         345     345           
+ Misses      4244    4243    -1     
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairekuang clairekuang changed the title fix(revit): better reference point cache invalidation fix(revit): CNX-394 better reference point cache invalidation Aug 30, 2024
Copy link

linear bot commented Aug 30, 2024

@oguzhankoral oguzhankoral merged commit 7852b1d into dev Aug 30, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the claire/cnx-340-send-reference-and-survey-point-on-revit-root-collection branch August 30, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants